Replace instanceof checks in JsonThrowOnErrorDynamicReturnTypeExtension #4155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khartir
force-pushed
the
replace_instanceof_in_JsonThrowOnErrorDynamicReturnTypeExtension
branch
from
1736892 to
cbd6c91
Compare
staabm
approved these changes
Jul 25, 2025
ondrejmirtes
requested changes
Aug 30, 2025
|
|
||
| $secondArgType = $scope->getType($args[1]->value); | ||
| $secondArgValue = $secondArgType instanceof ConstantScalarType ? $secondArgType->getValue() : null; | ||
| $secondArgValue = count($secondArgType->getConstantScalarValues()) === 1 ? $secondArgType->getConstantScalarValues()[0] : null; |
There was a problem hiding this comment.
$secondArgType->getConstantScalarValues() with more than one value should also be properly handled here
Khartir
force-pushed
the
replace_instanceof_in_JsonThrowOnErrorDynamicReturnTypeExtension
branch
from
2993e14 to
b9665f5
Compare
Khartir
force-pushed
the
replace_instanceof_in_JsonThrowOnErrorDynamicReturnTypeExtension
branch
from
b9665f5 to
5099a0d
Compare
|
Thank you! |
Khartir
deleted the
replace_instanceof_in_JsonThrowOnErrorDynamicReturnTypeExtension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope this is OK, I just cloned this rule for thecodingmachine/phpstan-safe-rule#61 and found these deprecated checks.